[RFC -mm][PATCH 5/6] prepare kprobes code for x86 unification

[Arjan van de Ven]

On Mon, 10 Dec 2007 17:53:22 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:
> +#define stack_addr(regs) ((unsigned long *)&regs->sp)


Hi,

thanks for taking up this work again, however this line has a bug (yes it's a bug in the 32 bit retprobes);
the address of the stack is regs->sp not &regs->sp, since &regs->sp is the address of the memory we store the stackpointer in, not the actual address on the stack...

Greetings,
  Arjan van de Ven