[Bug runtime/2497] STP_STRING_SIZE set by stap is too small

[guanglei at cn dot ibm dot com]

------- Additional Comments From guanglei at cn dot ibm dot com  2006-04-05 00:17 -------
(In reply to comment #11)
> OK, I see the problem.  It seems the simplest thing is to just do what
> you proposed and either increase STP_STRING_SIZE or make it definable on
> the command line, or both. The only remaining use of STP_STRING_SIZE is
> for strings used while doing stack traces, so it seems like a good idea
> to set it higher by default, because the current default is not useful.
> Maybe 512 or 1024?  
I think only making STP_STRING_SIZE definable is ok. But it may be better if we
can also increase the default value of STP_STRING_SIZE to 512, which should have
no side effect. 512 is my estimated and I think it should be enough.

> You can check in the change, or I will if you prefer.
Oh, I don't have the permissions to check into CVS. It's good if you can do this
for me.

> By the way, in the above example, what is the purpose of
> this_event_len()?  It seems that you have defined "%n" to write the
> length of the finished string to that location, but why does that need
> an argument?
this_event_len() will always 0 for LKET, the real length will be calculated at
the end of bin_vsnwrite. So this_event_len() is just showing that the current
argument represents the length of the data to be written.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2497

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.