[PATCH] kprobe-booster: boosting multi-probe

[Prasanna S Panchamukhi]

Masami,

Please see few coding style issues inline below marked with "^^^".

Thanks
Prasanna
> 
> +static inline void boost_aggr_kprobe(struct kprobe *ap)
> +{
> +        struct kprobe *kp;
> +	if (ap->post_handler || ap->break_handler) {
	^^^^^^^^^^^
Could you please, leave a line after local variables as shown below
        struct kprobe *kp;

	if (ap->post_handler || ap->break_handler) {


>  			kfree(old_p);
>  		}
>  		arch_remove_kprobe(p);
> +	} else {
> +		boost_aggr_kprobe(old_p);
>  	}
^^^^^^^^^
This does not look good, could you please remove the "{" for else
condition, since it is just a single line, as shown below
	else
		boost_aggr_kprobe(old_p);



-- 
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-51776329