[RFC][Patch 1/2][take3]kprobe: kprobe-booster against 2.6.15-rc5-mm3 for i386
Ananth N Mavinakayanahalli
ananth@in.ibm.com
Wed Jan 25 04:51:00 GMT 2006
On Tue, Jan 24, 2006 at 10:23:02PM +0900, Masami Hiramatsu wrote:
> Hi, Ananth
>
> Ananth N Mavinakayanahalli wrote:
> > On Thu, Dec 22, 2005 at 10:23:56PM +0900, Masami Hiramatsu wrote:
> >
> >>Hi,
> >>
> >>Here is a patch to clean up kprobe's resume_execute() for i386 arch.
> >>Before applying kprobe-booster, I'd like to cleanup codes.
> >>It is useful for simplify booster patch.
> >
> > Hi Masami,
> >
> > This patch looks fine except for some coding-style issues (^^^ below).
>
> Thank you for review. I will fix those coding style issues.
>
> >>+
> >>+ no_change:
> > ^^^^ no spaces for goto labels.
> >
> >
> >>+ return ;
> > ^^^ spurious whitespace
>
> Then, here is OK?
> ---
> no_change:
> return;
> ---
Yes
Ananth
More information about the Systemtap
mailing list