Review patches of user space kprobe

Prasanna S Panchamukhi prasanna@in.ibm.com
Fri Jan 6 09:08:00 GMT 2006


> >>readpage() routine reads one page at a time. we map the page one time and walk the
> >>probes list for this inode, insert all the probes within this page and then unmap it.
> Yes, I did see codes inserting all the probes on the page, but below codes:
> +		if (kprobe_page_mapped) {
> +			unmap_uprobe_page(up);
> +			unlock_page(up->page);
> +		}
> 
> are only executed after the loop of hlist_for_each_entry. Is it correct?
> 

that's correct. The page is mapped only once for the first match in the loop, 
then all the probes are inserted into that page in the hlist_for_each loop and
then the page is unmapped only once after the end of the loop.

Thanks
Prasanna
-- 
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-25044636



More information about the Systemtap mailing list