[Patch 2/5][Djprobe]Djprobe Coexist with Kprobes

[Masami Hiramatsu]

Hi,

Ananth N Mavinakayanahalli wrote:
> On Thu, Sep 29, 2005 at 09:59:31PM +0900, Masami Hiramatsu wrote:
> 
> Few comments on first glance...

Thank you!

>>+	spin_lock(&djprobe_lock);
> 
> 
> Please use _irqsave/_irqrestore versions at all places.

OK, I will use it.


>>+	/* make a new instance */
>>+	djpi = kmalloc(sizeof(struct djprobe_instance),GFP_KERNEL);
> 
> 
> You are under a spinlock... this kmalloc may sleep.

Oh, it's a my mistake. I will change to GFP_ATOMIC.

> 
> Follow CodingStyle please! There are a few other places in the existing
> kprobes code that also need a CodingStyle cleanup, but that is for a
> later patch.

OK, I will check my codes by using ./scripts/Lindent, and post patches again.

Thanks,
Best regards,

-- 
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp