[discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64

Prasanna S Panchamukhi prasanna@in.ibm.com
Thu Sep 29 14:14:00 GMT 2005


>On Thu, Sep 29, 2005 at 08:43:44AM +0800, Zhang, Yanmin wrote:
>>  <<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
>> when reading the source codes. Basically, the bug could break
>> kprobe_insn_pages under multi-thread environment. PPC arch also has the
>> problem.

>Can you describe what the problem actually is? 

Andi,

The up()/down() orders are incorrect in arch/x86_64/kprobes.c file while
trying to get/remove a kprobes instruction slot in arch_prepare_kprobe() 
and arch_remove_kprobe() routines. Zhang's patch corrects this.


Thanks
Prasanna
-- 

Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@in.ibm.com>



More information about the Systemtap mailing list