Runtime probes to load module parameters

Frank Ch. Eigler fche@redhat.com
Wed Aug 3 00:49:00 GMT 2005


Hien Nguyen <hien@us.ibm.com> writes:

> -		execl("/sbin/insmod",  "insmod", modname, buf, NULL);
> +		char cmd[2048];
> +		sprintf(cmd, "/sbin/insmod %s %s", modname, buf);
> +		execl("/bin/sh", "sh", "-c", cmd, NULL); 
> [...]

I don't think systemtap would have any use for this option.
Regardless, it would be nice to stay away from something as insecure
as system() (or its equivalent being used here) for those extra args.

- FChE



More information about the Systemtap mailing list