[patch 1/4] Kprobes support for IA64
Lynch, Rusty
rusty.lynch@intel.com
Tue May 24 16:20:00 GMT 2005
>From: Keith Owens [mailto:kaos@sgi.com]
>Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> wrote:
>>
>>This patch adds the kdebug die notification mechanism needed by
Kprobes.
>> case 0: /* unknown error (used by GCC for
__builtin_abort()) */
>>+ if (notify_die(DIE_BREAK, "kprobe", regs, break_num,
>TRAP_BRKPT, SIGTRAP)
>>+ == NOTIFY_STOP) {
>>+ return;
>>+ }
>> die_if_kernel("bugcheck!", regs, break_num);
>> sig = SIGILL; code = ILL_ILLOPC;
>> break;
>
>Nit pick. Any break instruction in a B slot will set break_num 0, so
>you cannot tell if the break was inserted by kprobe or by another
>debugger. Setting the string to "kprobe" is misleading here, change it
>to "break 0".
Good catch. We'll update the informational string.
--rusty
More information about the Systemtap
mailing list