CPU disassembler-memory accessor

Frank Ch. Eigler fche@redhat.com
Wed May 29 08:53:00 GMT 2002


Hi -

bje wrote:
> [...]
> The following patch adds a third accessor to CPUs for the purpose of
> providing the disassembler with access to the instruction memory
> without causing undesirable side effects in the memory hierarchy.
> [...]

Thanks.

> [...] Any comments?

Yes, just one.  The read_disasm_memory_1 function is methinks
overengineered.  It doesn't need to throw exceptions, nor handle
accesses of other sizes.  Actually, why not just do a direct
sid::bus-level read() on the accessor and do away with the
read_disasm_memory* thingie altogether?


- FChE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/sid/attachments/20020529/555b8382/attachment.sig>


More information about the Sid mailing list