More helpful error message during path walk

Daniel Jacobowitz drow@false.org
Tue Dec 4 16:12:00 GMT 2007


I don't remember if I've sent this before, but I couldn't find a
record of it.  I was working on a filesystem where nftw64 failed
(maybe permissions?  bad symlink?  I don't remember, sorry), and
nothing eventually led to an error message.  So prelink failed to
prelink some files I expected it to, but didn't say why not.  The
obvious patch made it much clearer what was happening.

-- 
Daniel Jacobowitz
CodeSourcery

2007-04-30  Daniel Jacobowitz  <dan@codesourcery.com>

	* gather.c (gather_object): Print an error if nftw64 fails.

Index: gather.c
===================================================================
--- gather.c	(revision 152)
+++ gather.c	(working copy)
@@ -1004,6 +1004,8 @@ gather_object (const char *name, int der
       ++implicit;
       ret = nftw64 (name, gather_func, 20, flags | FTW_ACTIONRETVAL);
       --implicit;
+      if (ret < 0)
+	error (0, errno, "Failed searching %s", name);
 #ifndef HAVE_FTW_ACTIONRETVAL
       free (blacklist_dir);
       blacklist_dir = NULL;



More information about the Prelink mailing list