Error trying to get CVS write access via web-form

[Christopher Faylor]

On Fri, Apr 02, 2004 at 11:17:40AM -0500, Frank Ch. Eigler wrote:
>cgf wrote:
>> [...]
>> >I think this regex should either be corrected or the page should
>> >explain that the comment can only be of this form.
>> 
>> You have the source, right?  Does anything suggest itself to you?
>
>Would committing this patch bother anyone?

Doesn't the comment part have to include something with an '@' in it?

Doesn't your change essentially make the validity check "See if there
is something following a space at the end of the line.  If there is
then that's good, otherwise, that's good too."

Of course, that's what the previous line does, too, so I guess it's in
good company.

cgf

>Index: ps_form.cgi
>===================================================================
>RCS file: /cvs/sourceware/cgi-bin/pdw/ps_form.cgi,v
>retrieving revision 1.41
>diff -u -r1.41 ps_form.cgi
>--- ps_form.cgi	30 Sep 2003 15:27:04 -0000	1.41
>+++ ps_form.cgi	2 Apr 2004 16:16:21 -0000
>@@ -87,7 +87,7 @@
> &start_html;
> 
> if ($ssh_key !~ /^\s*\d{3,}\s+\d+\s+\d{100,}(\s+[^\n]*)?$/
>-    && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+\s+\S+\@\S+$/o
>+    && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+(\s+[^\n]*)?$/o
>     && $ssh_key !~ /gnats only/o)
> {
>     print "Your identity.pub entry is incorrectly formatted.  Please press Back on your browser and copy the contents of your identity.pub file into the form.  If you believe you have gotten this message erroneously, please submit a complete bug report to <a href=\"mailto:overseers\@sources.redhat.com\">overseers\@sources.redhat.com</a>.<p>";
>
>
>- FChE