[PATCH] newlib: m68k-atari-elf, fixed naming bug in defines

[micael@hildenborg.com]

Hi Corinna,

I'm sorry for causing confusion and taking up unnecessary time. Try to see this as a comical example of my autism spectrum shining through...

The patch was a follow up to a mail from John Johnston on the 17th november, where he found a problem with one out of fixe patches I mailed. So obviously I should have replied to him and not posted it directly on the mailing list.

But while we are at it I might as well ask what the proper procedure is for my case:
I posted a mail containing five pacthes (five commits).
If one of them contains a problem and needs to be fixed, how should that be done?
Adding a patch to the list, making it six patches, where the last fixes the problem?
Or should the problematic patch (commit) be redone correctly?

Again, sorry for taking up your time.

/Mikael.




Den fredag 28 november 2025 kl. 13:13:15 +01:00, skrev Corinna Vinschen <vinschen@redhat.com>:

> Hi Mikael,
> 
> On Nov 18 19:07, <micael@hildenborg.com> wrote:
> 
> > Fix to a reported problem in naming of defines.
> > 
> > 
> > /Mikael Hildenborg.
> > 
> > 
> 
> > From 65b71bd50631da48343b97fecdade55e7c1122f4 Mon Sep 17 00:00:00 2001
> > From: Mikael Hildenborg <<micael@hildenborg.com>>
> > Date: Tue, 18 Nov 2025 18:40:48 +0100
> > Subject: [PATCH] m68k-atari-elf: fixed naming bug in defines.
> > 
> > ---
> > libgloss/m68k/atari/atari-gettod.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/libgloss/m68k/atari/atari-gettod.c b/libgloss/m68k/atari/atari-gettod.c
> > index 75139ed8c..c8227ae5e 100644
> > --- a/libgloss/m68k/atari/atari-gettod.c
> > +++ b/libgloss/m68k/atari/atari-gettod.c
> > @@ -14,8 +14,8 @@
> > The code below uses that limitation to simplify the code.
> > */
> > 
> > -#define SEC_1900_TO_1980 315529200
> > -#define SEC_1900_TO_MAX 0x7fffffff
> > +#define SEC_1970_TO_1980 315529200
> > +#define SEC_1970_TO_MAX 0x7fffffff
> > #define SECONDS_IN_A_DAY (24 * 60 * 60)
> > #define SEC_JAN_AND_FEB ((31 + 29) * SECONDS_IN_A_DAY)	// In a leap year
> > #define SECONDS_IN_A_YEAR (365 * SECONDS_IN_A_DAY)
> > 
> SEC_1900_TO_1980 is set to 2524521600 in git, so this hunk doesn't apply.
> Can you check and resend a new patch, please?
> 
> Also, if you don't mind, please add a more helpful commit message.
> It doesn't even mention the affected macros...
> 
> 
> Thanks,
> Corinna
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/newlib/attachments/20251129/ad30acf3/attachment.htm>