[PATCH 1/5] libgloss: msp430: delete outdated/wrong code

Mike Frysinger vapier@gentoo.org
Wed Dec 27 03:24:49 GMT 2023


The #if 0 & comment imply this code doesn't exist and is never used,
except there's another #if Lrun_fini_array section below which *does*
define this function, which makes this code comment confusing.  This
seems to be a hold over of the cleanup of the minrt code in the old
commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove
.init/.fini sections").
---
 libgloss/msp430/crt0.S | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S
index 88876cd48300..c0b258f508d2 100644
--- a/libgloss/msp430/crt0.S
+++ b/libgloss/msp430/crt0.S
@@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array
 END_CRT_FUNC	run_init_array
 #endif /* Lrun_init_array */
 
-;; FIXME: There are currently no program termination routines executed for
-;; msp430.
-#if 0
-#if Lrun_fini_array
-;; Ensure global C++ destructors in .fini_array are called on exit
-;; by registering __crt0_run_fini_array with atexit.
-START_CRT_FUNC 0700 register_fini_array
-
-	mov_	#__crt0_run_fini_array, R12
-	call_	#atexit
-
-END_CRT_FUNC	register_fini_array
-#endif /* Lrun_fini_array */
-#endif /* 0 */
 
 #if Lmain
 ;; This function is always included and calls main().
-- 
2.43.0



More information about the Newlib mailing list