[PATCH, RFC v3 0/3] add xtensa port

Jeff Johnston jjohnstn@redhat.com
Tue Aug 15 22:09:58 GMT 2023


Looks better.  I notice that in your previous patches you tweaked the code
in Makefile.am from the original patch 1 which I applied.  In the
previous patch2 you had:

diff --git a/newlib/Makefile.am b/newlib/Makefile.am
index 126cf24c1..e29607ccd 100644
--- a/newlib/Makefile.am
+++ b/newlib/Makefile.am
@@ -240,7 +240,7 @@ stmp-targ-include: config.status
        $(AM_V_at)s=machine/$(machine_dir)/include d= $(TARG_INCLUDE_CP_DIR)
        $(AM_V_at)s=sys/$(sys_dir)/include d= $(TARG_INCLUDE_CP_DIR)
        $(AM_V_at)for i in $(call
rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
-         f=`echo $$i | sed s:$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+         f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
          $(MKDIR_P) targ-include/`dirname $$f`; \
          cp $$i targ-include/$$f; \
        done
@@ -334,7 +334,7 @@ install-data-local: install-toollibLIBRARIES
install-multi $(INSTALL_DATA_LOCAL)
            else true; fi ; \
          done ; \
          for i in $(call
rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
-           f=`echo $$i | sed s:$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+           f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`;
\
            $(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
            $(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
          done ; \

Is this change required and is missing from this latest Patch 2 or did you
change your mind regarding the change?

-- Jeff J.

On Tue, Aug 15, 2023 at 3:20 PM Alexey Lapshin <alexey.lapshin@espressif.com>
wrote:

> Ahh, yes, sorry for that, resending
>


More information about the Newlib mailing list