[PATCH] Fix getlogin() to check only stdin to get a valid tty

Jeff Johnston jjohnstn@redhat.com
Tue Jul 18 17:44:33 GMT 2023


Yes, sorry.  Your patch didn't apply so I quickly manually changed it and
messed it up.
Fix applied.

-- Jeff J.

On Tue, Jul 18, 2023 at 3:08 AM Jordi Sanfeliu <jordi@fibranet.cat> wrote:

> Hello Jeff,
>
> I'm reviewing the patch you applied to getlogin.c and it seems to me
> that there is an extra opening parenthesis.
>
> You forgot the diff line:
>
>   +  if ((tty = ttyname (0)) == 0)
>
> Can you confirm it?
>
> Regards.
>
>
>
> On 7/17/23 21:06, Jeff Johnston wrote:
> > Original patch pushed, thanks.
> >
> > -- Jeff J.
> >
>
> --
> Jordi Sanfeliu
> FIBRANET Network Services Provider
> https://www.fibranet.cat
>
>


More information about the Newlib mailing list