[PATCH] newlib: libc: Optimize the string functions
Brian Inglis
Brian.Inglis@SystematicSw.ab.ca
Tue Dec 13 20:02:51 GMT 2022
On 2022-08-16 05:08, Corinna Vinschen wrote:
> Hi Seija,
>
> Thanks for the patch.
>
> First of all, your patch is broken in terms of whitespaces and line
> breaks, so it can't be applied. I suspect your MUA is doing that
> automatically. You better provide the git patch as attachement, or
> change your MUA settings to leave whitespaces and line breaks alone.
...> ...this one.
>
> Sorry, but I've given up after about half of the patch. I don't see why
> this is only a single huge patch. If there's any problem, multiple
> smaller patches are easier to understand, and easier to revert or
> bisect.
>
> Please resend this patch as a patchset, preferredly one file per patch
> including a matching commit message per patch. The aforementioned
> bugfix should be a separate patch in the patchset.
Should we not also require some background info in PATCH 0/N on what compiler
is "optimized" on what platform and by how much space and time?
If only some compilers or platforms, then code should go in conditionals.
Jeopardy: What is "the root of all evil?" Premature optimization.
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer but when there is no more to cut
-- Antoine de Saint-Exupéry
More information about the Newlib
mailing list