[PATCH] Remove use of _global_impure_ptr

Corinna Vinschen vinschen@redhat.com
Wed May 4 13:34:28 GMT 2022


Hi Sebastian,

On May  3 15:40, Sebastian Huber wrote:
> Remove the pointer indrection through the read-only _global_impure_ptr and
> directly use a globally visible _impure_data object of type struct reent.  This
> enables the static initialization of global data structures in a follow up
> patch.  In addition, we get rid of a machine-specific file.

the patch looks good.  I just wonder if we really need the
impure-compat.c file.  Backward-compat is no problem for embedded stuff,
and Cygwin doesn't expose _global_impure_ptr to user space either.

If there's no other compelling reason, you can just drop it and push
the rest.


Thanks,
Corinna



More information about the Newlib mailing list