[PATCH] newlib: remove unused fenv flags
Mon Feb 14 17:51:06 GMT 2022
On Mon, Feb 14, 2022, 10:50 AM C Howland <firstname.lastname@example.org> wrote:
> On Sat, 12 Feb 2022 at 15:42, Mike Frysinger <email@example.com> wrote:
> > On 11 Feb 2022 11:10, C Howland wrote:
> > > On Fri, 11 Feb 2022 at 05:09, Mike Frysinger wrote:
> > > > On 10 Feb 2022 14:18, C Howland wrote:
> > > > > First, would be if a machine directory can override just some
> > files
> > > > > from the main--as if viewpathed--and this can also apply to the
> > makefile.
> > > > > (Does the machine directory totally replace the main branch
> > directory, or
> > > > > can it be supplemental? My impression was a viewpath model, which
> > can be
> > > > > supplementary or replace all.) If I'm wrong about this, no
> > no
> > > > > objection for this specific reason.
> > > >
> > > > assuming "viewpathed" means "VPATH in the makefile", then no, that's
> > not
> > > > how newlib works. that is how glibc works, so maybe you're thinking
> > of that.
> > > > newlib compiles all objects in all subdirs in isolation. it then
> > assembles
> > > > the final libm.a/libc.a in a specific order (with the machine dir
> > last).
> > > > so it adds fenv/*.o to libm.a by basename, then replaces any existing
> > ones
> > > > with machine/$arch/*.o.
> > >
> > > Yes, I meant as in VPATH in a makefile with individual file
> > > So, yes, I was thinking not the right thing for newlib, sorry for
> > > conflating Newlib with other things.
> > i'm not sure pulling off a vpath build in newlib would be that easy. or
> > least, it would require writing more custom logic that we get for free
> > we use automake. at this point, with the size of newlib, i'm not sure we
> > would gain that much. yes, we double compile the common code, but since
> > the
> > files are small and so few, so eh.
> > > OK, neither you nor Joel think templating for the makefile to be of
> > > use, that makes a majority in comments so far and I'll go along.
> > > fenv is special and tricky I think we would be better off with better
> > > instructions for this one particularly, as it would encourage/help
> > > to add new targets.)
> > > I agree that these specific compiler options do need care taken. But
> > > that's part of the reason they're good examples for the fenv
> > > as that's a tricky subject that needs special attention and might need
> > > things like them. But at the same time I agree that they are also for
> > the
> > > same reason potentially dangerous to suggest.
> > with the new unified non-recursive automake patch i posted, it actually
> > would be feasible to put compiler settings in one makefile and have them
> > apply to others (by declaring the flags by filename). but the question
> > of whether we even want to do that in the first place is still open.
> > -mike
> Given the "take whole machine directory" model, it's probably best to take
> this patch as proposed. The thoughts about templating fenv to keep it easy
> for people not familiar with automake stuff, trying to avoid that aspect
> being an impediment to people taking on doing fenv for a new platform, can
> be handled separately by adding some separate notes.
I don't know that any of the fenv implementations would have benefited from
a template approach anyway. All the ones I was involved in ported from some
other existing source. We just tried to minimize the changes as we merged
it into the newlib structure.
Certainly if someone does implement it from scratch for newlib first, they
can always copy from an existing implementation. But unless it is unusual
embedded only architecture, will probably always port from another project.
More information about the Newlib