[PATCH 3/5] libgloss: merge libgloss into top-level Makefile

Corinna Vinschen vinschen@redhat.com
Mon Feb 7 11:49:17 GMT 2022


On Feb  7 06:14, Mike Frysinger wrote:
> On 05 Feb 2022 00:46, Mike Frysinger wrote:
> > +if CONFIG_LIBNOSYS
> > +include libnosys/Makefile.inc
> > +endif
> > --- a/libgloss/configure.ac
> > +++ b/libgloss/configure.ac
> > @@ -230,10 +230,7 @@ dnl if test "${config_testsuite}" = "true";
> >  dnl   then AC_CONFIG_SUBDIRS([testsuite])
> >  dnl fi
> >  
> > -if test "${config_libnosys}" = "true"; then
> > -  AC_CONFIG_FILES([libnosys/Makefile])
> > -  subdirs="$subdirs libnosys"
> > -fi
> > +AM_CONDITIONAL(CONFIG_LIBNOSYS, test x$config_libnosys = xtrue)
> >  
> >  LIB_AC_PROG_CC
> >  AS=${AS-as}
> 
> i'm not super happy with the CONFIG_xxx naming.  newlib doesn't seem to have
> an existing convention for me to copy & paste.  there is LIB*_MACHINE_DIR,
> but those correspond to specific machine/xxx/ subdirs.
> 
> i guess i could use the newlib pattern and name these HAVE_xxx_DIR.
> -mike

Just keep it as is for now, it's easier to follow.  Name changes can go
into another patch(set).


Corinna



More information about the Newlib mailing list