[PATCH 1/7] newlib: libm: merge machine/ trampoline up a level

Jon Turney jon.turney@dronecode.org.uk
Thu Jan 27 15:28:50 GMT 2022

On 27/01/2022 02:46, Mike Frysinger wrote:
> On 26 Jan 2022 15:58, Jon Turney wrote:
>> On 23/01/2022 06:04, Mike Frysinger wrote:
>>> The machine/{configure,Makefile} files exist only to fan out to the
>>> specific machine/$arch/ subdir.  We already have all that same info
>>> in the libm/ dir itself, so by moving the recursive configure and
>>> make calls into it, we can cut off this logic entirely and save the
>>> overhead.
>>> For arches that don't have a machine subdir, it means they can skip
>>> the logic entirely.
>> It looks like this (and the following commint) breaks 'man info' and
>> 'make man'?
>> (e.g. https://github.com/cygwin/cygwin/runs/4949106511)
> blah, sorry about that.  i have another series pending related to man page
> unification that i've been testing with and doesn't have this issue.  but
> that's still under review, so i pushed this quick hack fix since my series
> deletes this entire chunk of code.
> -mike

I hadn't noticed before, but there also seems to be something in this 
series which seems to break building for x86.

(see https://github.com/cygwin/cygwin/actions/runs/1754176435)

>   CC       lib_a-f_exp.o
> In file included from ../../../../../../newlib/libm/machine/i386/f_exp.c:29:
> ../../../../../../newlib/libm/machine/i386/f_math.h:5:10: fatal error: fdlibm.h: No such file or directory
>     5 | #include "fdlibm.h"
>       |          ^~~~~~~~~~

More information about the Newlib mailing list