[PATCH 2/2] newlib/doc/makedoc.c: if realloc() fails, exit with an error message.

Joel Sherrill joel@rtems.org
Fri Jun 18 00:52:40 GMT 2021


I see you replied but I don't see a comment.

On Thu, Jun 17, 2021, 6:33 PM C Howland <cc1964t@gmail.com> wrote:

> > ------------------------------
> > *From:* Newlib <newlib-bounces+craig.howland=caci.com@sourceware.org> on
> > behalf of Joel Sherrill <joel@rtems.org>
> > *Sent:* Thursday, June 17, 2021 5:53 PM
> > *To:* newlib@sourceware.org <newlib@sourceware.org>
> > *Subject:* [PATCH 2/2] newlib/doc/makedoc.c: if realloc() fails, exit
> > with an error message.
> >
> >
> > ---
> >  newlib/doc/makedoc.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/newlib/doc/makedoc.c b/newlib/doc/makedoc.c
> > index 966349c51..81aa6f941 100644
> > --- a/newlib/doc/makedoc.c
> > +++ b/newlib/doc/makedoc.c
> > @@ -135,6 +135,11 @@ catchar (string_type *buffer, char ch)
> >    {
> >      buffer->size *=2;
> >      buffer->ptr = realloc(buffer->ptr, buffer->size);
> > +    if (!buffer->ptr)
> > +    {
> > +      fprintf(stderr,"Can't allocate memory\n");
> > +      exit(1);
> > +    }
> >    }
> >
> >    buffer->ptr[buffer->write_idx ++ ] = ch;
> > --
> > 2.24.4
> >
> > Both patches look sane.
>


More information about the Newlib mailing list