[PATCH v2] libc/time: Move internal newlib tz-structs to local.h

Torbjorn SVENSSON torbjorn.svensson@st.com
Thu Oct 15 16:47:37 GMT 2020


Hello Corinna,

Thanks for the feedback and I hope that you had a nice vacation!

I haven't run tests with your patch applied, but just reading it should be fine.
I see no reason why "sys/_tz_structs.h" would be included from "bits/stdc++.h", and it is this particular include chain that is causing the problems in the libstdc ++ test suite, so if it works for Cygwin, I'd say go for it!

Kind regards,
Torbjörn

-----Original Message-----
From: Corinna Vinschen <vinschen@redhat.com> 
Sent: den 15 oktober 2020 12:22
To: Torbjorn SVENSSON <torbjorn.svensson@st.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h

On Oct 15 06:52, Torbjorn SVENSSON via Newlib wrote:
> Ping!

Due to vacation I only just checked now.  The patch breaks the Cygwin
build.  Especially __tzinfo_type has to be exposed from a public header
in newlib.

So what about the attached patch instead?


Corinna


More information about the Newlib mailing list