[PATCH] riscv: fix integer wraparound in memcpy
PkmX
pkmx.tw@gmail.com
Fri Jul 24 11:07:45 GMT 2020
This patch fixes a bug in RISC-V's memcpy implementation where an
integer wraparound occurs when src + size < 8 * sizeof(long), causing
the word-sized copy loop to be incorrectly entered.
Signed-off-by: Chih-Mao Chen <cmchen@andestech.com>
---
newlib/libc/machine/riscv/memcpy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/libc/machine/riscv/memcpy.c
b/newlib/libc/machine/riscv/memcpy.c
index 07e8e0076..4098f3ab1 100644
--- a/newlib/libc/machine/riscv/memcpy.c
+++ b/newlib/libc/machine/riscv/memcpy.c
@@ -51,9 +51,9 @@ small:
const long *lb = (const long *)b;
long *lend = (long *)((uintptr_t)end & ~msk);
- if (unlikely (la < (lend - 8)))
+ if (unlikely (lend - la > 8))
{
- while (la < (lend - 8))
+ while (lend - la > 8)
{
long b0 = *lb++;
long b1 = *lb++;
--
2.27.0
More information about the Newlib
mailing list