[PATCH] Remove multiple defination error
Eshan Dhawan
eshandhawan51@gmail.com
Sat Jul 11 17:18:13 GMT 2020
On Sat, Jul 11, 2020 at 8:46 PM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:
> On 11/07/2020 00:41, Eshan dhawan wrote:
>
> > Signed-off-by: Eshan dhawan<eshandhawan51@gmail.com>
> > ---
> > newlib/libm/machine/arm/fenv-vfp.c | 7 ++++-
> > newlib/libm/machine/arm/fenv.c | 47 +++++++++++++++++++-----------
> > 2 files changed, 36 insertions(+), 18 deletions(-)
>
> What are the design goals of this implementation? Should it work with
> some sort of run time VFP detection? Should it select the support using
> builtin defines?
>
It used the GCC flags to detect VPF
if VPF is not selected all the symbols of vfp won't appear :)
>
> I would use builtin defines only and then just use a single file.
>
I tried converting into a single file but the file becomes too complex to
handle and check for errors. :)
More information about the Newlib
mailing list