[PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7)

Eric Blake eblake@redhat.com
Wed Jul 31 17:13:00 GMT 2019


On 7/31/19 11:38 AM, Alexander Fedotov wrote:

Way too long for the subject line (which should ideally be less than 70
characters, and should be a one-line summary of what is changing), and
missing a commit message body (that's where you can go into the details,
including why the change is worthwhile, rather than just pointing to a URL).


> ---
>  libgloss/arm/syscalls.c        | 12 ++++++------
>  newlib/libc/sys/arm/crt0.S     |  7 +++++++
>  newlib/libc/sys/arm/syscalls.c |  9 +++++++--
>  3 files changed, 20 insertions(+), 8 deletions(-)

I should know what the patch is intended to do by the time I get to this
point in the email, but "Reflect commits" with two URLs as an
overly-long subject has failed to do that. Can you please resubmit with
a better commit message?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/newlib/attachments/20190731/89dc9503/attachment.sig>


More information about the Newlib mailing list