[PATCH] Include "xlocale.h", not <xlocale.h>.

Yaakov Selkowitz yselkowi@redhat.com
Thu Jun 13 23:00:00 GMT 2019

On Wed, 2019-06-12 at 10:05 +0200, Corinna Vinschen wrote:
> Hi Michael,
> On Jun 11 19:43, Michael Haubenwallner wrote:
> > libX11 does provide an <X11/Xlocale.h>, and while building libX11
> > itself, they add their include/X11 to the compiler's include path.
> > Now when newlib headers include <xlocale.h> on the case insensitive
> > file system, the compiler does pick their Xlocale.h.
> > So we better include "xlocale.h" in newlib headers instead, to prefer
> > newlib xlocale.h from within newlib headers.
> Commit 90e35b1eb3df renamed _locale.h to xlocale.h in March 2017 under
> the assumption that we should provide the locale_t type in the same file
> as on Linux, FreeBSD, and Darwin.
> A few weeks later (June 2017), glibc removed the xlocale.h file in favor
> of bits/types/locale_t.h, which shouldn't be included directly anyway.
> For reference and the reasoning, see
> https://sourceware.org/git/?p=glibc.git;a=commit;h=f0be25b6336d
> Given that glibc and thus Linux stopped providing the non-standard
> xlocale.h header, I'd favor reverting 90e35b1eb3df.

I concur, please proceed.  Any packages which still expect <xlocale.h>
should have a patch in Fedora by now.

Yaakov Selkowitz
Senior Software Engineer - Platform Enablement
Red Hat, Inc.

More information about the Newlib mailing list