[Arm] SP and SL initialization refactored
Richard Earnshaw (lists)
Wed Apr 10 14:55:00 GMT 2019
On 10/04/2019 15:23, Corinna Vinschen wrote:
> Hi Richard,
> On Apr 10 13:26, Richard Earnshaw (lists) wrote:
>> On 19/03/2019 13:54, Alexander Fedotov wrote:
>>> Hi all
>>> In continue of threads
>>> https://sourceware.org/ml/newlib/2019/msg00117.html and
>>> I have reworked stack pointer initialization and stack limit as well.
>>> General idea behind of all these changes is to provide hook for
>>> flexibility (including semihosting when debug tap is used) and improve
>>> readability of existing crt0 code.
>>> And now code makes SP initialization in Thumb mode :)
>>> Any comments are very appreciated.
>> Apologies once again for the delayed review.
>> A small plea: when posting patches, please can you ensure that your
>> attachments are text/patch, or something similar, so that replies will
>> include the contents (and I can view them directly in the email rather
>> than having to mess about extracting the attachment).
> Ideally the patches are inline patches sent with `git send-email' or
> equivalent. I added some wording in terms of how to provide patches to
> https://sourceware.org/newlib/ lately. Do you have a suggestion for
> improving this?
Not really; When I use git format-patch with --attach I get
text/x-patch as the MIME type, which is fine. Problems only start if
users have poorly configured mail client that attach as octet-stream or
other binary types. Then mail clients can't display the attachment
inline as they don't know the format is really displayable.
More information about the Newlib