[Arm] Stack pointer setup thumb
Thu Mar 7 15:46:00 GMT 2019
> I hope you are have some memories on this fix :)
Not really :-(
> Is this still relevant ?
The whole patch, or just part of it ?
> The problem is that users complaining that it has different behavior
> in ARM and Thumb modes for one Cortex-R core. And they do expected
> that library will make some minimal initialization in both ISA
Well to be honest I really do not remember what prompted this patch in
the first place. So if you have a fix which makes the users happy and
which does not break anything then I would say "go for it". :-)
> Should we just remove this ?
> +#ifdef __thumb2__
> + /* XXX Fill in stack assignments for interrupt modes. */
Sure - I would have no problems with that. The comment was more
of a suggestion that someone needs to make sure that the stack
pointer is set up before interrupts happen, but it does not have
to be in this particular piece of code. Plus presumably this has
already been done, or else many more people would be complaining
about interrupts not working in Thumb mode.
More information about the Newlib