[PATCH] Remove matherr, and SVID and X/Open math library configurations
Jozef Lawrynowicz
jozef.l@mittosystems.com
Tue Jan 22 20:52:00 GMT 2019
On Wed, 16 Jan 2019 09:50:00 +0100
Corinna Vinschen <vinschen@redhat.com> wrote:
> Your patch was fine, just the problem of stopping to export a symbol
> from Cygwin worried me.
>
> We don't want to break an older application to run just because we
> removed a function from the DLL. On reading your mail and further
> reading up on matherr it seems this isn't really a problem.
>
> If we *really* get a complaint on the Cygwin mailing list, we can
> resurrect matherr just as an exportable symbol for Cygwin.
Ok, sounds good.
> Can you please resend your patch?
I've attached the original patch (0001-*), but also 3 further patches which
make some additional improvements to the float math functions.
0002-Newlib-Remove-HUGE_VAL-definition-from-libm-math-fun.patch
This patch removes the definitions of HUGE_VAL from some of the float math
functions. HUGE_VAL is defined in newlib/libc/include/math.h, so it is not
necessary to have a further definition in the math functions.
0003-Newlib-Use-HUGE_VALF-instead-of-HUGE_VAL-in-single-p.patch
This patch replaces instances of "(float).*HUGE_VAL" with a direct usage of
HUGE_VALF, which is also defined in math.h.
0004-Newlib-Use-nanf-instead-of-nan-in-single-precision-f.patch
This patch further reduces code size for a few single-precision float math
functions, by using nanf() instead of nan() where required.
I've regtested the patches with the GCC testsuite for arm-unknown-eabi, and I
built Cygwin and regtested it with "make check".
Thanks,
Jozef
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-matherr-and-SVID-and-X-Open-math-library-conf.patch
Type: text/x-patch
Size: 138200 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20190122/efc02294/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Newlib-Remove-HUGE_VAL-definition-from-libm-math-fun.patch
Type: text/x-patch
Size: 17768 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20190122/efc02294/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Newlib-Use-HUGE_VALF-instead-of-HUGE_VAL-in-single-p.patch
Type: text/x-patch
Size: 7244 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20190122/efc02294/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Newlib-Use-nanf-instead-of-nan-in-single-precision-f.patch
Type: text/x-patch
Size: 1785 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20190122/efc02294/attachment-0003.bin>
More information about the Newlib
mailing list