[Aarch64] Fix _lseek prototype
Christophe Lyon
christophe.lyon@linaro.org
Fri Oct 5 09:22:00 GMT 2018
On Tue, 2 Oct 2018 at 08:38, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>
> On Tue, 2 Oct 2018 at 00:18, Eric Blake <eblake@redhat.com> wrote:
> >
> > On 10/1/18 4:35 PM, Christophe Lyon wrote:
> > > Hi,
> > >
> > > While building newlib for Aarch64, I noticed a warning in _lseek. This
> > > small patch fixes the prototype.
> > >
> >
> > > +++ b/libgloss/aarch64/syscalls.c
> > > @@ -449,6 +449,7 @@ _swilseek (int fd, int ptr, int dir)
> > > return -1;
> > > }
> > >
> > > +int
> > > _lseek (int fd, int ptr, int dir)
> >
> > Why int and not off_t?
> >
> Because that's how the prototype is defined at the beginning of the same file.
>
> Maybe time to revisit this?
>
Here is an updated version using "off_t" instead of "int".
OK?
> > --
> > Eric Blake, Principal Software Engineer
> > Red Hat, Inc. +1-919-301-3266
> > Virtualization: qemu.org | libvirt.org
-------------- next part --------------
commit 93793741f0e43f091186f6ebf3690577f5388ba0
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date: Mon Oct 1 19:10:10 2018 +0000
[Aarch64] Fix _lseek prototype
2018-10-01 Christophe Lyon <christophe.lyon@linaro.org>
* libgloss/aarch64/syscalls.c (_lseek): Fix prototype.
diff --git a/libgloss/aarch64/syscalls.c b/libgloss/aarch64/syscalls.c
index e6dd4bd..9e77230 100644
--- a/libgloss/aarch64/syscalls.c
+++ b/libgloss/aarch64/syscalls.c
@@ -66,7 +66,7 @@ int _open (const char *, int, ...);
int _swiopen (const char *, int);
int _write (int, char *, int);
int _swiwrite (int, char *, int);
-int _lseek (int, int, int);
+off_t _lseek (int, int, int);
int _swilseek (int, int, int);
int _read (int, char *, int);
int _swiread (int, char *, int);
@@ -449,6 +449,7 @@ _swilseek (int fd, int ptr, int dir)
return -1;
}
+off_t
_lseek (int fd, int ptr, int dir)
{
return _swilseek (fd, ptr, dir);
More information about the Newlib
mailing list