[PATCH v2] Improve performance of strstr

Eric Blake eblake@redhat.com
Wed Oct 3 16:06:00 GMT 2018


On 10/3/18 8:27 AM, Wilco Dijkstra wrote:
> v2: Add documentation comment back in. Reduce size of shift table further to
> gain another 10% performance on short strings.

I haven't reviewed the patch itself (although in theory it sounds fine), 
however:

> 
> Tested against GLIBC testsuite and passes randomized tests.

Passing the glibc testsuite isn't all that reassuring, as they just 
barely had to squash a strstr bug this year that was not caught by their 
testsuite at the time:

https://sourceware.org/bugzilla/show_bug.cgi?id=23637

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



More information about the Newlib mailing list