[PATCH] Improve sincosf comments

Corinna Vinschen vinschen@redhat.com
Thu Aug 16 15:25:00 GMT 2018


On Aug 16 10:39, Wilco Dijkstra wrote:
> Corinna Vinschen wrote:
>   
> > Patch is ok, but we can really drop the CVS-style ChangeLogs now.  A
> > nice explanation of the changes would be more helpful, including a word
> > on the name change pi64 -> pi63.
> 
> That is good news! How about the following:
> 
> 
> Improve comments in sincosf implementation to make the code easier
> to understand.  Rename the constant pi64 to pi63 since it's actually 
> PI * 2^-63.  Add comments for fields of sincos_t structure.  Add comments
> describing implementation details to reduce_fast.

Pushed, thanks!


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20180816/a2863ed7/attachment.sig>


More information about the Newlib mailing list