[PATCH] implicit Unicode data tables generation

Corinna Vinschen vinschen@redhat.com
Tue Mar 13 10:46:00 GMT 2018


On Mar 12 20:32, Thomas Wolff wrote:
> Am 12.03.2018 um 15:21 schrieb Corinna Vinschen:
> > A build dependency to unicode-ucd should not be required.  Why not have
> > automatic build rules which are simply skipped if the file doesn't
> > exist?  So somebody can download the file and the rules do the rest?
> > It's not *that* important, but a nice feature.
> The easiest way would be that the mkunidata scripts just ignore the missing
> files, like in the patch attached.
> On the other hand, in my original scripts I had the additional fallback
> option to download them from unicode.org on demand.
> If that's acceptable in a build process, I could add that back in.
> Or just drop those rules and stay explicit?

Implicit would be nice, it's not actually a hard requirement.

We must not rely on system-installed files outside the source tree,
build tree or outside the toolchain.

Please provide a patch removing any ln to files under /usr/share, etc.
The explicit rules add a rule to download the Unicode.txt file into the
src tree.  That's the only file we may rely on.  If it doesn't exist,
an implicit rule should not break the build.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20180313/9fc99460/attachment.sig>


More information about the Newlib mailing list