[PATCH 1/6] generated character data for libc/ctype

[Can Finner]

On Mon, Mar 12, 2018 at 10:42 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
> On Mar  8 00:18, Thomas Wolff wrote:
>> Makefile add-ons for both patch series (libc/string and libc/ctype) will be
>> sent separately.
>
>> From 4cd871bea1c6cf677d57587a7e844bb9cb3b19be Mon Sep 17 00:00:00 2001
>> From: Thomas Wolff <towo@towo.net>
>> Date: Sun, 25 Feb 2018 16:29:33 +0100
>> Subject: [PATCH 1/6] generated case conversion data, Unicode 10.0
>> [...]
>
> Patchset pushed.  I just squashed the makefile patch into the previous
> patch to avoid a repository state not building.
Hi,
This patch breaks arm-none-eabi cross toolchain build with below error message:

/data/.../obj/gcc1/gcc/xgcc -B/data/.../obj/gcc1/gcc/
-B/data/.../obj/newlib/arm-none-eabi/thumb/newlib/ -isystem
/data/.../obj/newlib/arm-none-eabi/thumb/newlib/targ-include -isystem
/data/.../newlib-cygwin/newlib/libc/include
-B/data/.../obj/newlib/arm-none-eabi/thumb/libgloss/arm
-L/data/.../obj/newlib/arm-none-eabi/thumb/libgloss/libnosys
-L/data/.../newlib-cygwin/libgloss/arm  -mthumb
-DPACKAGE_NAME=\"newlib\" -DPACKAGE_TARNAME=\"newlib\"
-DPACKAGE_VERSION=\"3.0.0\" -DPACKAGE_STRING=\"newlib\ 3.0.0\"
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -I.
-I/data/.../newlib-cygwin/newlib/libc/ctype -D__NO_SYSCALLS__
-D_COMPILING_NEWLIB -fno-builtin      -g -ffunction-sections
-fdata-sections -O2  -mthumb -c -o lib_a-categories.o `test -f
'categories.c' || echo
'/data/.../newlib-cygwin/newlib/libc/ctype/'`categories.c
/data/.../newlib-cygwin/newlib/libc/ctype/categories.c:5:17: error:
width of 'cat' exceeds its type
   enum category cat: 11;
                 ^~~
make[8]: *** [lib_a-categories.o] Error 1

Newlib is configured as:

$ grep TOPLEVEL config.log
TOPLEVEL_CONFIGURE_ARGUMENTS='/data/.../newlib-cygwin/configure
--disable-newlib-supplied-syscalls --enable-newlib-io-long-long
--enable-newlib-io-c99-formats --enable-newlib-mb
--target=arm-none-eabi --prefix=/ --with-pkgversion=unknown'

Also, it might be better to send patch series in the form of:
[PATCH 0/n] Subject_0
[PATCH 1/n] Subject_1
...
[PATCH m/n] Subject_m

So each patch is described, sent and reviewed as an independent
thread.  It's really hard for people not understand the code to find
which patch breaks which code, if patches are sent as reply messages
to previous one.

Thanks,
bin
>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat



-- 
Regards.