[PATCH 3/3] width data generation script

[Corinna Vinschen]

On Mar  1 18:28, Corinna Vinschen wrote:
> On Feb 27 23:30, Thomas Wolff wrote:
> > Am 27.02.2018 um 16:03 schrieb Corinna Vinschen:
> > > On Feb 26 22:40, Thomas Wolff wrote:
> > > >  From 5a7793cb8788ca4a1624f2a8af9d723b0edc6ab4 Mon Sep 17 00:00:00 2001
> > > > From: Thomas Wolff <towo@towo.net>
> > > > Date: Sun, 25 Feb 2018 16:26:48 +0100
> > > > Subject: [PATCH 3/3] width data generation script
> > > This patch, too, should explain in a few sentences why and how we're
> > > switching to generated data in the commit message.
> > Do you want the description in all 3 commits of the patch series, the main
> > or the first of them?
> 
> It's sufficient to add the description to one commit message (in the
> correct format).  The one adding the data files might be a good choice.
> 
> > > Other than that, the patches look ok to me, provided the integration
> > > of generating the data into Makefile.am / Makefile.in is forthcoming.
> > I am not familiar with these makefile prototype formats and their workflow.
> > If I can just copy the respective makefile parts verbatim into Makefile.am,
> > that's OK, otherwise I'm asking for support.
> 
> This was basically answered by Hans-Bernhard in his reply to your other
> mail: https://sourceware.org/ml/newlib/2018/msg00181.html

Adding a bit more info here:

newlib/Makefile.am should get a new target to allow rebuilding the data
files.  It could just cd into $(srcdir) and call a script there, that's
sufficent.  Copy over the new target to newlib/Makefile.in, build the
project, and test building the data files from the newlib build dir
(e.g. <your build root>/x86_64-pc-cygwin/newlib by invoking the new
target.  When that works as desired, you're done.

The patch you send to this list only needs to contain the change to
newlib/Makefile.am, not the change to newlib/Makefile.in.  I'll
regenerate that file before pushing your patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20180302/c8c423c7/attachment.sig>