[PATCH v2 2/2] newlib/.../getreent.c: Allow to be provided by host and do so for RTEMS

Florian Schmidt Florian.Schmidt@neclab.eu
Tue Nov 14 08:01:00 GMT 2017


On 11/13/2017 10:59 AM, Corinna Vinschen wrote:
> I never actively noticed this dummy var stuff.  I still think this is
> really ugly.  What should have happened is that the source file is
> simply not built in these cases, rather than to include a dummy var.
> But it's apparently historic and given that this is common practice in
> newlib, I pushed your patch.

Speaking of which: I was also a bit confused as to what these dummy 
variables are supposed to do. However, that reminds me of something I 
noticed the other day when we experimented with newlib code: realloc.c 
contains a dummy variable name that looks wrong, and in fact clashes 
with the one from calloc.c. I'll send a patch for discussion.

Florian

-- 
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Networked Systems and Data Analytics Group
NEC Laboratories Europe, Network Research Division
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@neclab.eu
============================================================
NEC Europe Ltd | Registered Office: Athene, Odyssey
Business Park, West End Road, London, HA4 6QE, GB
Registered in England 2832014



More information about the Newlib mailing list