[PATCH] for newlib/libc/strnstr.c newlib/libm/complex/cargl.c (was: Warnings in new code)

Brian Inglis Brian.Inglis@SystematicSw.ab.ca
Wed Sep 13 22:00:00 GMT 2017


On 2017-09-12 14:18, Yaakov Selkowitz wrote:
> Recent additions to newlib have caused some warnings:
> 
> newlib/libc/string/strnstr.c:47:15: warning: implicit declaration of
> function ‘memmem’ [-Wimplicit-function-declaration]
> newlib/libm/complex/cargl.c:16:25: warning: implicit declaration of
> function ‘imag’ [-Wimplicit-function-declaration]
> newlib/libm/complex/cargl.c:16:35: warning: implicit declaration of
> function ‘real’ [-Wimplicit-function-declaration]

Patches attached, with your build fixes, fix recent build problems.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
-------------- next part --------------
From b1eb2d986886ef1c6687629b870ec22e0ed80b03 Mon Sep 17 00:00:00 2001
From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
Date: Wed, 13 Sep 2017 00:25:07 -0600
Subject: [PATCH 1/2] newlib/libc/string/strnstr.c define _GNU_SOURCE for
 memmem()

---
 newlib/libc/string/strnstr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/newlib/libc/string/strnstr.c b/newlib/libc/string/strnstr.c
index ce32d0f73..f6b007813 100644
--- a/newlib/libc/string/strnstr.c
+++ b/newlib/libc/string/strnstr.c
@@ -31,6 +31,7 @@ QUICKREF
 */
 
 #undef __STRICT_ANSI__
+#define _GNU_SOURCE
 #include <_ansi.h>
 #include <string.h>
 
-- 
2.14.1

-------------- next part --------------
From 93d7e133dd06daea1dde38e193365446a40a8897 Mon Sep 17 00:00:00 2001
From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
Date: Wed, 13 Sep 2017 00:26:48 -0600
Subject: [PATCH 2/2] newlib/libm/complex/cargl.c change imag() real() to
 cimagl() creall()

---
 newlib/libm/complex/cargl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libm/complex/cargl.c b/newlib/libm/complex/cargl.c
index d2885a459..790cffe8f 100644
--- a/newlib/libm/complex/cargl.c
+++ b/newlib/libm/complex/cargl.c
@@ -13,6 +13,6 @@ cargl(long double complex z)
        #ifdef _LDBL_EQ_DBL
          return carg (z);
        #else
-         return atan2l (imag (z), real (z));
+         return atan2l (cimagl (z), creall (z));
        #endif
 }
-- 
2.14.1



More information about the Newlib mailing list