[AArch64] use stack symbol provided by linker for nosys

Alexander Fedotov alfedotov@gmail.com
Tue Aug 15 14:20:00 GMT 2017


Yes, old fashion habits )

Alex


On Tue, Aug 15, 2017 at 4:57 PM, Tamar Christina
<Tamar.Christina@arm.com> wrote:
>> -----Original Message-----
>> From: Alexander Fedotov [mailto:alfedotov@gmail.com]
>> Sent: 15 August 2017 14:35
>> To: Tamar Christina
>> Cc: Szabolcs Nagy; newlib@sourceware.org; nd
>> Subject: Re: [AArch64] use stack symbol provided by linker for nosys
>>
>> Yes, there is a typo - it should be ARM_RDI_MONITOR
>
> Think you forgot to submit it as a git format-patch :)
>
>>
>> Thanks  !
>>
>> On Tue, Aug 15, 2017 at 3:46 PM, Tamar Christina
>> <Tamar.Christina@arm.com> wrote:
>> >> > diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
>> >> > index
>> >> > 3bf0278..0c669d9 100644
>> >> > --- a/libgloss/aarch64/crt0.S
>> >> > +++ b/libgloss/aarch64/crt0.S
>> >> > @@ -83,7 +83,7 @@
>> >> >     FUNC_START      _start
>> >> >
>> >> >  /* Start by setting up a stack */
>> >> > -
>> >> > +#ifdef ARM_RDI_MONITOR
>> >>
>> >> i think this should match
>> >>
>> >> ...
>> >> > +#ifdef ARM_RDP_MONITOR
>> >
>> > We don't define ARM_RDP_MONITOR in AArch64, so this should be
>> ARM_RDI_MONITOR.
>> >
>> >>
>> >> this.
>> >>
>> >> >  .LC0:
>> >> >     GEN_DWORD HeapBase
>> >
>>
>>
>>
>> --
>> Best regards,
>> AF



-- 
Best regards,
AF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: aarch64_fix_typo.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170815/344084ff/attachment.bin>


More information about the Newlib mailing list