Importing inttypes methods
Fri Jul 28 18:24:00 GMT 2017
On 7/28/2017 6:02 AM, Aditya Upadhyay wrote:
> Just give a little time. I am creating a new patch set that fix the
> BSD_VISIBLE problem.
And just to be clear the standards based guards go in the .h
file. Not in the C body.
For example, any BSD specific methods have their
prototype wrapped in __BSD_VISIBLE. See strings.h
for an example.
> On Fri, Jul 28, 2017 at 4:13 PM, Corinna Vinschen <firstname.lastname@example.org> wrote:
>> On Jul 27 19:30, Aditya Upadhyay wrote:
>>> I apologize for the inconvenience caused. Actually i am new to git and
>>> still learning commands. I am trying my best and want to assure you
>>> that i will be familiar with the git soon. I will try not to repeat
>>> the same mistakes again in future.
>>> I am attaching the fresh new patches for last 4 methods with all
>>> possible changes. I am requesting you to please review the patches.
>> Patches are fine and what we talked about, but I realized belatedly
>> that we have a problem with the inttypes.h header file:
>> Your patch includes xlocale.h only if __POSIX_VISIBLE >= 200809.
>> However, you declare the _l functions unconditionally. This will
>> break builds which don't define _POSIX_SOURCE to the right value.
>> Additionally, these functions are BSD-only at the moment. They are
>> neither in glibc nor in POSIX.
>> So, what we should do here is this:
>> * Include xlocale.h only if __BSD_VISIBLE.
>> * Declare the _l functions only if __BSD_VISIBLE, too.
>> It's your choice now: Do you want to recreate the below patches
>> accordingly, or shall I aplly the patches as they are, and you create
>> a followup patch just fixing inttypes.h?
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35806
Support Available (256) 722-9985
More information about the Newlib