Importing inttypes methods
Wed Jul 26 12:02:00 GMT 2017
On Wed, Jul 26, 2017 at 4:38 PM, Corinna Vinschen <firstname.lastname@example.org> wrote:
> On Jul 26 01:20, Aditya Upadhyay wrote:
>> Hello All,
>> I have ported the inttypes methods from freeBSD. I have made all the
>> possible changes whatever my mentors suggested me. I am requesting you
>> to please review the same. Is this ok for master ?
> The patches apply and build. This looks 99% good now, thank you.
> Just one last minor problem, which is my fault, not yours:
> You named the reentrant functions _strtoimax_r, _wcstoumax_r, etc.,
> which is basically right.
> However, the *other*, equivalent reentrant, locale-specific functions
> for other datatypes are all named with a trailing l: _strtol_l,
> _wcstoull_l, etc. In retrospect, this wasn't the brightest idea,
> but the API has been exported this way, so I'm reluctant to change
> it after the fact.
> Would you mind to call your new functions with trailing 'l' rather
> than 'r', too, to use the same naming convention, please?
I will keep your points in mind whenever i will port a new function.
> Oh, btw., please make sure the patches have no trailing whitespace.
> That's not really a problem, but `git am' complains about them.
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
More information about the Newlib