Importing inttypes methods from FreeBSD

Aditya Upadhyay aadit0402@gmail.com
Thu Jul 20 08:25:00 GMT 2017


Hello All,

This is the modified patches for inttypes methods. Now I want to make
testsuite for these methods in newlib, but i have no idea how to make
test in newlib. Can anyone please help me for the same or point me
some link. Please review the patch.

Thanks & Regards,
Aditya Upadhyay

On Wed, Jul 19, 2017 at 10:30 PM, Aditya Upadhyay <aadit0402@gmail.com> wrote:
> I am attaching the patch for inttypes methods after modification. I am
> requesting you to please review the same.
>
> Regards,
> Aditya
>
> On Wed, Jul 19, 2017 at 9:14 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jul 19 10:13, Craig Howland wrote:
>>> On 07/19/2017 08:28 AM, Corinna Vinschen wrote:
>>> > What you really want is to define a static function which takes the
>>> > reent pointer and strtoimax_l/strtoimax only calling that, like this:
>>> >
>>> > --- snip ---
>>> > static intmax_t
>>> > _strtoimax_r(struct _reent *rptr, const char * __restrict nptr,
>>> >          char ** __restrict endptr, int base, locale_t loc)
>>> Corinna:
>>>      Why static?  In general, the reentrant forms are included in the header
>>> files so that they can be called directly if an application so desires.
>>
>> Good point.  Yes, the function should better be non-static and added
>> to inttypes.h as well (unconditionally).
>>
>>
>> Corinna
>>
>> --
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-importing-of-imaxabs-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 1460 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Importing-of-imaxdiv-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 1176 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Importing-strtoimax-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 1219 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Importing-strtoumax-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 5074 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Importing-wcstoimax-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 5284 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Importing-wcstoumax-inttypes-method-from-FreeBSD.patch
Type: text/x-patch
Size: 5230 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170720/15b1af98/attachment-0005.bin>


More information about the Newlib mailing list