Importing cacoshl.c and its dependent methos,
Corinna Vinschen
vinschen@redhat.com
Wed Jun 21 08:28:00 GMT 2017
On Jun 21 08:46, Sebastian Huber wrote:
> On 21/06/17 04:24, aditya upadhyay wrote:
>
> > Hello Developers,
> > In cacoshl.c, There is a dependency between cacoshl.c and csqrtl.c.
> > In ported csqrtl.c from NetBSD, stdbool.h is there, But i saw there
> > is no stdbool.h.
> >
> > So for bool data type, I have used enum. Is it a right way or not.
> > please suggest or do i have to use stdbool.h from gcc library ?
>
> <stdbool.h> is currently not used by Newlib. I am not sure if we should add
> this dependency if its only needed by csqrtl.c (in overall NetBSD libm) and
> not visible to the user.
>
> I would replace the #include <stdbool.h> with
>
> #ifndef __cplusplus
> typedef enum { false, true } bool;
> #endif
>
> and keep the rest of the code unchanged.
Wait. Isn't stdbool.h available in gcc for ages? When building newlib,
shouldn't we be able to rely on c99 being available?
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170621/46e780a9/attachment.sig>
More information about the Newlib
mailing list