[PATCH 2/3, newlib] Only define static locks in multithreaded mode

Thomas Preudhomme thomas.preudhomme@foss.arm.com
Fri Feb 10 11:12:00 GMT 2017


Hi,

I've removed the changes to lock.h as requested. Please find attached an updated 
patch in git format-patch format.

Best regards,

Thomas

On 31/01/17 17:21, Thomas Preudhomme wrote:
> And in git format-patch now.
>
> Best regards,
>
> Thomas
>
> On 31/01/17 17:10, Thomas Preudhomme wrote:
>> Hi,
>>
>> Newlib build system defines __SINGLE_THREAD__ to allow concurrency code
>> to be only compiled when newlib is configured for multithread. One such
>> example are locks which become useless in single thread mode. Although
>> most static locks are indeed guarded by !defined(__SINGLE_THREAD__),
>> some are not.
>>
>> This commit adds these missing guards to __dd_hash_mutex,
>> __atexit_recursive_mutex, __at_quick_exit_mutex and __arc4random_mutex.
>> It also makes sure locking macros in lock.h are noop in single thread
>> mode.
>>
>> Is this ok for master?
>>
>> Best regards,
>>
>> Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: guard_static_lock_single_thread.patch
Type: text/x-patch
Size: 5334 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20170210/b8a647cd/attachment.bin>


More information about the Newlib mailing list