[PATCH 2/3] arm: Remove optpld macro

Kyrill Tkachov kyrylo.tkachov@foss.arm.com
Thu Jan 26 15:41:00 GMT 2017


On 26/01/17 15:33, Corinna Vinschen wrote:
> On Jan 26 10:26, Kyrill Tkachov wrote:
>> Here and in other places in the patch you have a syntax error in the PLD instruction.
>> The syntax for the pld argument should be in square brackets as it's a memory address like so:
>> pld [r1].
>> With your patch the newlib build fails for armv7-a targets.
>> This patch fixes the build failures.
>>
>> Tested by making sure the newlib build completes successfully.
>>
>> Can someone please commit it for me if it's ok for master?
> Pushed.  Can you please provice patches in `git format-patch' layout in
> future?  For instance, since you replied to the existing thread, the
> subject in your log message needs manual intervention.

Thanks, will keep that in mind.

Kyrill

> Thanks,
> Corinna
>



More information about the Newlib mailing list