Semihosting fix
David Hoover
spm2@dangerous.li
Thu Apr 21 05:23:00 GMT 2016
Hi Corinna,
Here's the fixed patch. Thanks,
David
On 2016-04-20 11:09, Corinna Vinschen wrote:
> Hi David,
>
> On Apr 19 15:54, David Hoover wrote:
>> Hello,
>>
>> Code was introduced in commit 8d98f956cc398d086794e19051c3380d599022da
>> that breaks semihosting for ARM Cortex targets running in many
>> environments.
>> [...]
>> diff --git a/libgloss/arm/crt0.S b/libgloss/arm/crt0.S
>> index 7c662f9..b459e12 100644
>> --- a/libgloss/arm/crt0.S
>> +++ b/libgloss/arm/crt0.S
>> @@ -125,9 +125,11 @@
>>
>> /* Set __heap_limit. */
>> ldr r1, [r0, #4]
>> + cmp r1, #0
>> + beq .LC33
>> ldr r2, =__heap_limit
>> str r1, [r2]
>> -
>> +.LC33:
>> ldr r1, [r0, #0]
>> cmp r1, #0
>> bne .LC32
>
> Your patch doesn't apply cleanly because of TAB vs. SPC differences.
> Can you please resend your patch with fixed formatting (git
> format-patch
> might help)?
>
>
> Thanks,
> Corinna
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixed-semihosting-for-ARM-when-heapinfo-not-provided.patch
Type: text/x-diff
Size: 687 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20160421/f9890f36/attachment.bin>
More information about the Newlib
mailing list