[PATCH v2 1/2] Eliminate use of Newlib-specific <machine/types.h>

[Corinna Vinschen]

On Apr 13 09:29, Sebastian Huber wrote:
> This change solves a glibc/BSD compatibility problem.
> [...]
> @@ -31,6 +38,13 @@ typedef unsigned short __gid_t;
>  __extension__ typedef long long _off64_t;
>  #endif
>  
> +/* Probably only used by Cygwin */

I don't think so.  This comment is not needed.

> +#ifdef __GNUC__
> +__extension__ typedef long long int __loff_t;
> +#else
> +typedef long int __loff_t;
> +#endif
> +

Didn't you just write in your other mail that this is a bug?  Let's fix it.
The rest of the patch looks ok.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20160413/6d82b556/attachment.sig>