[PATCH] Define BSD u_intN_t types indiscriminately

Corinna Vinschen vinschen@redhat.com
Thu Mar 24 14:52:00 GMT 2016


On Mar 24 08:39, Eric Blake wrote:
> On 03/24/2016 04:08 AM, Corinna Vinschen wrote:
> > Is the below patch ok?  Glibc actually always defines u_intN_t
> > types, while we define them only on RTMES, XMK and Cygwin.
> > 
> 
> > -/* deprecated */
> > +/* BSD types, sanctioned by POSIX. */
> 
> "sanctioned" may be a bit strong; "permitted" might be better. Also,
> might be worth a note that the standard types such as uint8_t should be
> preferred; these BSD types are only provided for back-compat.
> 
> But otherwise the patch looks okay to me.

Thanks for reviewing.  I improved the comment per your suggestion.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20160324/b3ceb19c/attachment.sig>


More information about the Newlib mailing list