[PATCH] Fix "/*" within comment warning

Yaakov Selkowitz yselkowitz@cygwin.com
Mon Mar 21 15:09:00 GMT 2016


On 2016-03-21 09:50, Corinna Vinschen wrote:
> On Mar 21 09:11, Yaakov Selkowitz wrote:
>> On 2016-03-21 06:44, Corinna Vinschen wrote:
>>>> +/* These types are required by netinet/ *.h on Cygwin */
>>>>   #if __BSD_VISIBLE || defined(__CYGWIN__)
>>>>   #ifndef _BSDTYPES_DEFINED
>>>>   /* also defined in mingw/gmon.h and in w32api/winsock[2].h */
>>>
>>> Apart from the comment patch, do we really need "|| defined(__CYGWIN__)"
>>> here?
>>
>> The comment explains the very reason why those types are always needed.
>
> The comment doesn't really explain it.  Why is it needed for Cygwin
> if it's not needed for glibc?

Because our netinet headers are from BSD and use BSD types.

-- 
Yaakov



More information about the Newlib mailing list