Bug in openrisc __malloc_lock

Julius Schmidt julius.schmidt@argondesign.com
Mon Aug 3 09:32:00 GMT 2015

I believe there is a bug in the openrisc implementation of __malloc_lock:
The lines
	restore = or1k_critical_begin();
	_or1k_malloc_lock_restore = restore;
are executed every time _malloc_lock is called. If __malloc_lock is called recursively then the
old value of restore will be forgotten and so interrupts will remain disabled even after the
required number of __malloc_unlock calls.

Am I missing something or should these lines be moved into the if() statement?

Julius Schmidt
Argon Design

More information about the Newlib mailing list